[llvm] [GVN/PRE] Run tests for AArch64 triple too (PR #129073)

Madhur Amilkanthwar via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 08:13:41 PST 2025


https://github.com/madhur13490 updated https://github.com/llvm/llvm-project/pull/129073

>From f200b9ca3df0fe4872fd9f4761852321e79d1446 Mon Sep 17 00:00:00 2001
From: Madhur Amilkanthwar <madhura at nvidia.com>
Date: Thu, 27 Feb 2025 07:37:40 -0800
Subject: [PATCH] [GVN/PRE] Run tests for AArch64 triple too

The tests changed in the patch are running only
for some apple triple. It'd be good to compile them
for AArch64 triple too.
---
 llvm/test/Transforms/GVN/PRE/2009-06-17-InvalidPRE.ll         | 1 -
 .../Transforms/GVN/PRE/2011-06-01-NonLocalMemdepMiscompile.ll | 1 -
 llvm/test/Transforms/GVN/PRE/2017-06-28-pre-load-dbgloc.ll    | 1 -
 llvm/test/Transforms/GVN/PRE/2017-10-16-LoadPRECrash.ll       | 1 -
 .../GVN/PRE/2018-06-08-pre-load-dbgloc-no-null-opt.ll         | 1 -
 llvm/test/Transforms/GVN/PRE/atomic.ll                        | 3 +--
 llvm/test/Transforms/GVN/PRE/load-pre-licm.ll                 | 1 -
 llvm/test/Transforms/GVN/PRE/lpre-call-wrap-2.ll              | 1 -
 llvm/test/Transforms/GVN/PRE/lpre-call-wrap.ll                | 1 -
 llvm/test/Transforms/GVN/PRE/nonintegral.ll                   | 1 -
 llvm/test/Transforms/GVN/PRE/pre-gep-load.ll                  | 1 -
 llvm/test/Transforms/GVN/PRE/pre-load-implicit-cf-updates.ll  | 1 -
 llvm/test/Transforms/GVN/PRE/rle-phi-translate.ll             | 4 ++--
 13 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/llvm/test/Transforms/GVN/PRE/2009-06-17-InvalidPRE.ll b/llvm/test/Transforms/GVN/PRE/2009-06-17-InvalidPRE.ll
index 506ad7ce6cd35..95a3b5cbfcd10 100644
--- a/llvm/test/Transforms/GVN/PRE/2009-06-17-InvalidPRE.ll
+++ b/llvm/test/Transforms/GVN/PRE/2009-06-17-InvalidPRE.ll
@@ -4,7 +4,6 @@
 ; This is invalid as it bypasses the check for %m.0.ph==null in bb4.
 ; ModuleID = 'mbuf.c'
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
-target triple = "i386-apple-darwin9.6"
   %struct.mbuf = type { ptr, ptr, i32, ptr, i16, i16, i32 }
 
 define void @m_adj(ptr %mp, i32 %req_len) nounwind optsize {
diff --git a/llvm/test/Transforms/GVN/PRE/2011-06-01-NonLocalMemdepMiscompile.ll b/llvm/test/Transforms/GVN/PRE/2011-06-01-NonLocalMemdepMiscompile.ll
index 3f0475dc79ca2..05d505c603c75 100644
--- a/llvm/test/Transforms/GVN/PRE/2011-06-01-NonLocalMemdepMiscompile.ll
+++ b/llvm/test/Transforms/GVN/PRE/2011-06-01-NonLocalMemdepMiscompile.ll
@@ -4,7 +4,6 @@
 ; rdar://9429882
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
-target triple = "x86_64-apple-macosx10.7.0"
 define i1 @rb_intern(ptr %foo) nounwind ssp {
 ; CHECK-LABEL: @rb_intern(
 
diff --git a/llvm/test/Transforms/GVN/PRE/2017-06-28-pre-load-dbgloc.ll b/llvm/test/Transforms/GVN/PRE/2017-06-28-pre-load-dbgloc.ll
index b2b0216ed8f72..92c01002975de 100644
--- a/llvm/test/Transforms/GVN/PRE/2017-06-28-pre-load-dbgloc.ll
+++ b/llvm/test/Transforms/GVN/PRE/2017-06-28-pre-load-dbgloc.ll
@@ -26,7 +26,6 @@
 ;              ^
 
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
-target triple = "aarch64--linux-gnu"
 
 %struct.desc = type { ptr }
 %struct.node = type { ptr, ptr }
diff --git a/llvm/test/Transforms/GVN/PRE/2017-10-16-LoadPRECrash.ll b/llvm/test/Transforms/GVN/PRE/2017-10-16-LoadPRECrash.ll
index 04de10a5cc1dc..0c172dcfa565e 100644
--- a/llvm/test/Transforms/GVN/PRE/2017-10-16-LoadPRECrash.ll
+++ b/llvm/test/Transforms/GVN/PRE/2017-10-16-LoadPRECrash.ll
@@ -1,7 +1,6 @@
 ; RUN: opt -S -passes=gvn -enable-load-pre < %s | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
 
 %ArrayImpl = type { i64, ptr addrspace(100), [1 x i64], [1 x i64], [1 x i64], i64, i64, ptr addrspace(100), ptr addrspace(100), i8, i64 }
 
diff --git a/llvm/test/Transforms/GVN/PRE/2018-06-08-pre-load-dbgloc-no-null-opt.ll b/llvm/test/Transforms/GVN/PRE/2018-06-08-pre-load-dbgloc-no-null-opt.ll
index 2f63ed0016c2b..c238fe880cd5a 100644
--- a/llvm/test/Transforms/GVN/PRE/2018-06-08-pre-load-dbgloc-no-null-opt.ll
+++ b/llvm/test/Transforms/GVN/PRE/2018-06-08-pre-load-dbgloc-no-null-opt.ll
@@ -26,7 +26,6 @@
 ;              ^
 
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
-target triple = "aarch64--linux-gnu"
 
 %struct.desc = type { ptr }
 %struct.node = type { ptr, ptr }
diff --git a/llvm/test/Transforms/GVN/PRE/atomic.ll b/llvm/test/Transforms/GVN/PRE/atomic.ll
index e8bf25548ba89..ed530bec22e84 100644
--- a/llvm/test/Transforms/GVN/PRE/atomic.ll
+++ b/llvm/test/Transforms/GVN/PRE/atomic.ll
@@ -1,8 +1,7 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
-; RUN: opt -passes=gvn -S < %s | FileCheck %s
+; RUN: opt -S -passes=gvn < %s | FileCheck %s
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
-target triple = "x86_64-apple-macosx10.7.0"
 
 @x = common global i32 0, align 4
 @y = common global i32 0, align 4
diff --git a/llvm/test/Transforms/GVN/PRE/load-pre-licm.ll b/llvm/test/Transforms/GVN/PRE/load-pre-licm.ll
index 7028edb4732bd..efbc71b06256d 100644
--- a/llvm/test/Transforms/GVN/PRE/load-pre-licm.ll
+++ b/llvm/test/Transforms/GVN/PRE/load-pre-licm.ll
@@ -1,7 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -S -passes=gvn < %s | FileCheck %s
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128-n8:16:32"
-target triple = "i386-apple-darwin11.0.0"
 
 @sortlist = external global [5001 x i32], align 4
 
diff --git a/llvm/test/Transforms/GVN/PRE/lpre-call-wrap-2.ll b/llvm/test/Transforms/GVN/PRE/lpre-call-wrap-2.ll
index 177b8a080bb0a..dde5c225e4ff6 100644
--- a/llvm/test/Transforms/GVN/PRE/lpre-call-wrap-2.ll
+++ b/llvm/test/Transforms/GVN/PRE/lpre-call-wrap-2.ll
@@ -10,7 +10,6 @@
 ;     outbuf[outcnt] = bi_buf;
 ;   }
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
-target triple = "i386-apple-darwin7"
 @outcnt = common global i32 0		; <ptr> [#uses=3]
 
 define void @bi_windup(ptr %outbuf, i8 zeroext %bi_buf) nounwind {
diff --git a/llvm/test/Transforms/GVN/PRE/lpre-call-wrap.ll b/llvm/test/Transforms/GVN/PRE/lpre-call-wrap.ll
index 1f6a5c7a11a89..06a7f11aff14b 100644
--- a/llvm/test/Transforms/GVN/PRE/lpre-call-wrap.ll
+++ b/llvm/test/Transforms/GVN/PRE/lpre-call-wrap.ll
@@ -15,7 +15,6 @@
 ; void testfunction(A& iter) { A const end; while (iter != end) ++iter; }
 ;
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
-target triple = "i386-apple-darwin7"
   %struct.A = type { i32, i32 }
 
 define void @_Z12testfunctionR1A(ptr %iter) {
diff --git a/llvm/test/Transforms/GVN/PRE/nonintegral.ll b/llvm/test/Transforms/GVN/PRE/nonintegral.ll
index 240c985b23580..d989e81b8e76c 100644
--- a/llvm/test/Transforms/GVN/PRE/nonintegral.ll
+++ b/llvm/test/Transforms/GVN/PRE/nonintegral.ll
@@ -2,7 +2,6 @@
 ; RUN: opt -passes=gvn -S < %s | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:4"
-target triple = "x86_64-unknown-linux-gnu"
 
 define void @nipre(ptr noalias %p, ptr noalias %p2, i8 %jmp) {
 
diff --git a/llvm/test/Transforms/GVN/PRE/pre-gep-load.ll b/llvm/test/Transforms/GVN/PRE/pre-gep-load.ll
index 6b5211ebc00cc..edadcbead2223 100644
--- a/llvm/test/Transforms/GVN/PRE/pre-gep-load.ll
+++ b/llvm/test/Transforms/GVN/PRE/pre-gep-load.ll
@@ -4,7 +4,6 @@
 ; RUN: opt < %s -aa-pipeline=basic-aa -passes="gvn<load-pre>" -enable-load-pre=false -S | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"
-target triple = "aarch64--linux-gnu"
 
 define double @foo(i32 %stat, i32 %i, ptr %p) {
 ; CHECK-LABEL: @foo(
diff --git a/llvm/test/Transforms/GVN/PRE/pre-load-implicit-cf-updates.ll b/llvm/test/Transforms/GVN/PRE/pre-load-implicit-cf-updates.ll
index 331344b767436..0585781e7985f 100644
--- a/llvm/test/Transforms/GVN/PRE/pre-load-implicit-cf-updates.ll
+++ b/llvm/test/Transforms/GVN/PRE/pre-load-implicit-cf-updates.ll
@@ -1,7 +1,6 @@
 ; RUN: opt -S -passes=gvn -enable-load-pre < %s | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
 
 ; These tests exercise situations when instructions that were first instructions
 ; with implicit control flow get removed. We make sure that after that we don't
diff --git a/llvm/test/Transforms/GVN/PRE/rle-phi-translate.ll b/llvm/test/Transforms/GVN/PRE/rle-phi-translate.ll
index 519e0ca29a971..d23a95c5cb7cb 100644
--- a/llvm/test/Transforms/GVN/PRE/rle-phi-translate.ll
+++ b/llvm/test/Transforms/GVN/PRE/rle-phi-translate.ll
@@ -1,7 +1,7 @@
-; RUN: opt < %s -passes=gvn -S | FileCheck %s
+; RUN: opt < %s  -S -passes=gvn | FileCheck %s
+; RUN: opt < %s  -S -passes=gvn | FileCheck %s
 
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
-target triple = "i386-apple-darwin7"
 
 define i32 @test1(ptr %b, ptr %c) nounwind {
 ; CHECK-LABEL: @test1(



More information about the llvm-commits mailing list