[llvm] 8634635 - RegAllocFast: Stop reading uninitalized memory

[Benjamin Kramer via llvm-commits]

Author: Benjamin Kramer
Date: 2025-02-26T15:25:55+01:00
New Revision: 8634635d689c5a7adfb19cde4a313d7c02e95194

URL: https://github.com/llvm/llvm-project/commit/8634635d689c5a7adfb19cde4a313d7c02e95194
DIFF: https://github.com/llvm/llvm-project/commit/8634635d689c5a7adfb19cde4a313d7c02e95194.diff

LOG: RegAllocFast: Stop reading uninitalized memory

Found by msan.
==8138==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x559016395beb in allocVirtRegUndef llvm/lib/CodeGen/RegAllocFast.cpp:1010:6

Added: 
    

Modified: 
    llvm/lib/CodeGen/RegAllocFast.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/RegAllocFast.cpp b/llvm/lib/CodeGen/RegAllocFast.cpp
index 0f44f6da74685..3627bbb905176 100644
--- a/llvm/lib/CodeGen/RegAllocFast.cpp
+++ b/llvm/lib/CodeGen/RegAllocFast.cpp
@@ -982,6 +982,7 @@ void RegAllocFastImpl::allocVirtRegUndef(MachineOperand &MO) {
   if (!shouldAllocateRegister(VirtReg))
     return;
 
+  MO.setIsRenamable();
   LiveRegMap::iterator LRI = findLiveVirtReg(VirtReg);
   MCPhysReg PhysReg;
   if (LRI != LiveVirtRegs.end() && LRI->PhysReg) {
@@ -997,6 +998,7 @@ void RegAllocFastImpl::allocVirtRegUndef(MachineOperand &MO) {
       // basic.
       PhysReg = getErrorAssignment(*LRI, *MO.getParent(), RC);
       LRI->Error = true;
+      MO.setIsRenamable(false);
     } else
       PhysReg = AllocationOrder.front();
   }
@@ -1007,7 +1009,6 @@ void RegAllocFastImpl::allocVirtRegUndef(MachineOperand &MO) {
     MO.setSubReg(0);
   }
   MO.setReg(PhysReg);
-  MO.setIsRenamable(!LRI->Error);
 }
 
 /// Variation of defineVirtReg() with special handling for livethrough regs