https://github.com/shiltian approved this pull request. It seems like @arsenm 's comments have been resolved. LGTM. Please hold on for a moment. @arsenm might have more comments. https://github.com/llvm/llvm-project/pull/124527