[llvm] [PowerPC] Do not rely on MachineSink threshold to optimize CR spilling (PR #128745)

Min-Yih Hsu via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 11:40:01 PST 2025


================
@@ -165,7 +165,7 @@ class TargetInstrInfo : public MCInstrInfo {
 
   /// For a "cheap" instruction which doesn't enable additional sinking,
   /// should MachineSink break a critical edge to sink it anyways?
-  virtual bool shouldBreakCriticalEdgeToSink(MachineInstr &MI) const {
+  virtual bool shouldBreakCriticalEdgeToSink(const MachineInstr &MI) const {
----------------
mshockwave wrote:

nit: please don't touch unrelated part. This patch doesn't touch the users of shouldBreakCriticalEdgeToSink so adding const qualifier should be unrelated.

https://github.com/llvm/llvm-project/pull/128745


More information about the llvm-commits mailing list