[llvm] [CostModel] Handle vector struct results and cost `llvm.sincos` (PR #123210)

[David Sherwood via llvm-commits]

================
@@ -42,25 +44,31 @@ static cl::opt<bool> TypeBasedIntrinsicCost("type-based-intrinsic-cost",
     cl::desc("Calculate intrinsics cost based only on argument types"),
     cl::init(false));
 
+static cl::opt<bool> LibCallBasedIntrinsicCost(
+    "libcall-based-intrinsic-cost",
+    cl::desc("Calculate intrinsics cost using target library info"),
+    cl::init(false));
+
 #define CM_NAME "cost-model"
 #define DEBUG_TYPE CM_NAME
 
 PreservedAnalyses CostModelPrinterPass::run(Function &F,
                                             FunctionAnalysisManager &AM) {
   auto &TTI = AM.getResult<TargetIRAnalysis>(F);
+  auto &TLI = AM.getResult<TargetLibraryAnalysis>(F);
   OS << "Printing analysis 'Cost Model Analysis' for function '" << F.getName() << "':\n";
   for (BasicBlock &B : F) {
     for (Instruction &Inst : B) {
       // TODO: Use a pass parameter instead of cl::opt CostKind to determine
       // which cost kind to print.
       InstructionCost Cost;
       auto *II = dyn_cast<IntrinsicInst>(&Inst);
-      if (II && TypeBasedIntrinsicCost) {
-        IntrinsicCostAttributes ICA(II->getIntrinsicID(), *II,
-                                    InstructionCost::getInvalid(), true);
+      if (II && (LibCallBasedIntrinsicCost || TypeBasedIntrinsicCost)) {
+        IntrinsicCostAttributes ICA(
+            II->getIntrinsicID(), *II, InstructionCost::getInvalid(),
+            /*TypeBasedOnly=*/TypeBasedIntrinsicCost, &TLI);
----------------
david-arm wrote:

I must admit though it does seem a little odd now because `-type-based-intrinsic-cost` also implies libcall-based-intrinsic-cost since it causes `TLI` to be passed in. How about renaming `libcall-based-intrinsic-cost` to be `prefer-intrinsic-cost` or `use-intrinsic-cost`, since it's not really tied to the library calls?

This is just a suggestion, but if we had a `use-intrinsic-cost` option we could actually make it an enum along the lines of:

```
enum IntrinsicCostType {
  None,
  NonTypeBased,
  TypeBased,
};
```

that way you can collapse the two options into one and both `TypeBased` and `NonTypeBase` variants will use the TLI. However, I appreciate that would significantly increase the number of test files changed so it's possibly something for a follow-on?

https://github.com/llvm/llvm-project/pull/123210