[llvm] [llvm-objdump] Rework .gnu.version_d dumping (PR #128434)

[James Henderson via llvm-commits]

================
@@ -426,10 +394,26 @@ template <class ELFT> void ELFDumper<ELFT>::printSymbolVersion() {
         unwrapOrError(Elf.getSection(Shdr.sh_link), FileName);
     StringRef StrTab = unwrapOrError(Elf.getStringTable(*StrTabSec), FileName);
 
-    if (Shdr.sh_type == ELF::SHT_GNU_verneed)
+    if (Shdr.sh_type == ELF::SHT_GNU_verneed) {
       printSymbolVersionDependency(Shdr);
-    else
-      printSymbolVersionDefinition<ELFT>(Shdr, Contents, StrTab);
+    } else {
+      OS << "\nVersion definitions:\n";
----------------
jh7370 wrote:

What's the motivation to use a stored `OS` here rather than `outs()` directly, like in the old code?

https://github.com/llvm/llvm-project/pull/128434