[llvm] [FlattenCFG] Fix an Imprecise Usage of AA (PR #128117)

[Nikita Popov via llvm-commits]

================
@@ -381,6 +381,14 @@ class AAResults {
                      MemoryLocation::getBeforeOrAfter(V2));
   }
 
+  /// A convenience wrapper around the \c isNoAlias for two instructions.
+  bool isNoAlias(const Instruction *I1, const Instruction *I2) {
----------------
nikic wrote:

Using NoAlias terminology isn't right. Aliasing is a concept of memory locations. For instructions, you are interested in memory effects, as provided by getModRefInfo(). Adding a getModRefInfo() overload that accepts two instructions would be fine.

https://github.com/llvm/llvm-project/pull/128117