[llvm] [Utils] Avoid repeated hash lookups (NFC) (PR #128634)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 21:39:26 PST 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/128634
None
>From 6b37eb7828310ff767181a4f52077c248cc59cf7 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Mon, 24 Feb 2025 01:02:04 -0800
Subject: [PATCH] [Utils] Avoid repeated hash lookups (NFC)
---
.../Transforms/Utils/SampleProfileLoaderBaseImpl.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
index 44cb5183fb31d..390f284019bb4 100644
--- a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
+++ b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
@@ -745,8 +745,9 @@ bool SampleProfileLoaderBaseImpl<BT>::propagateThroughEdges(
if (i == 0) {
// First, visit all predecessor edges.
- NumTotalEdges = Predecessors[BB].size();
- for (auto *Pred : Predecessors[BB]) {
+ auto &Preds = Predecessors[BB];
+ NumTotalEdges = Preds.size();
+ for (auto *Pred : Preds) {
Edge E = std::make_pair(Pred, BB);
TotalWeight += visitEdge(E, &NumUnknownEdges, &UnknownEdge);
if (E.first == E.second)
@@ -757,8 +758,9 @@ bool SampleProfileLoaderBaseImpl<BT>::propagateThroughEdges(
}
} else {
// On the second round, visit all successor edges.
- NumTotalEdges = Successors[BB].size();
- for (auto *Succ : Successors[BB]) {
+ auto &Succs = Successors[BB];
+ NumTotalEdges = Succs.size();
+ for (auto *Succ : Succs) {
Edge E = std::make_pair(BB, Succ);
TotalWeight += visitEdge(E, &NumUnknownEdges, &UnknownEdge);
}
More information about the llvm-commits
mailing list