[llvm] [BOLT] pacret-scanner: fix regression tests... (PR #128565)
Alan Zhao via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 12:54:54 PST 2025
alanzhao1 wrote:
Thanks for your work on this! I'm still getting the following failure:
```
FAIL: BOLT :: binary-analysis/AArch64/gs-pacret-autiasp.s (154 of 518)
******************** TEST 'BOLT :: binary-analysis/AArch64/gs-pacret-autiasp.s' FAILED ********************
Exit Code: 1
Command Output (stderr):
--
RUN: at line 1: /usr/local/google/home/ayzhao/src/llvm-project/build/bin/clang --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -march=armv9.5-a+pauth-lr -mbranch-protection=pac-ret /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /usr/local/google/home/ayzhao/src/llvm-project/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
+ /usr/local/google/home/ayzhao/src/llvm-project/build/bin/clang --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -march=armv9.5-a+pauth-lr -mbranch-protection=pac-ret /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /usr/local/google/home/ayzhao/src/llvm-project/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
ld.lld: warning: cannot find entry symbol _start; not setting start address
RUN: at line 2: /usr/local/google/home/ayzhao/src/llvm-project/build/bin/llvm-bolt-binary-analysis --scanners=pacret /usr/local/google/home/ayzhao/src/llvm-project/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe 2>&1 | /usr/local/google/home/ayzhao/src/llvm-project/build/bin/FileCheck /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s
+ /usr/local/google/home/ayzhao/src/llvm-project/build/bin/llvm-bolt-binary-analysis --scanners=pacret /usr/local/google/home/ayzhao/src/llvm-project/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
+ /usr/local/google/home/ayzhao/src/llvm-project/build/bin/FileCheck /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s
/usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s:42:17: error: CHECK-LABEL: expected string not found in input
// CHECK-LABEL: GS-PACRET: non-protected ret found in function f_intermediate_overwrite1, basic block .LBB
^
<stdin>:8:82: note: scanning from here
GS-PACRET: non-protected ret found in function f1, basic block .Ltmp0, at address 10270
^
<stdin>:17:1: note: possible intended match here
GS-PACRET: non-protected ret found in function f_intermediate_overwrite1, basic block .Ltmp1, at address 10290
^
Input file: <stdin>
Check file: /usr/local/google/home/ayzhao/src/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s
-dump-input=help explains the following input dump.
Input was:
<<<<<<
1: BOLT-INFO: shared object or position-independent executable detected
2: BOLT-INFO: Target architecture: aarch64
3: BOLT-INFO: BOLT version: b335d5a8303250cb49901ecae7570adf61abbd3c
4: BOLT-INFO: first alloc address is 0x0
5: BOLT-INFO: creating new program header table at address 0x200000, offset 0x200000
6: BOLT-WARNING: non-relocation mode for AArch64 is not fully supported
7:
8: GS-PACRET: non-protected ret found in function f1, basic block .Ltmp0, at address 10270
label:42'0 X~~~~~~ error: no match found
9: The return instruction is 00010270: ret
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
10: The 1 instructions that write to the return register after any authentication are:
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11: 1. 0001026c: ldp x29, x30, [sp], #0x10
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12: This happens in the following basic block:
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13: 00010268: add x0, x0, #0x3
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14: 0001026c: ldp x29, x30, [sp], #0x10
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15: 00010270: ret
label:42'0 ~~~~~~~~~~~~~~~
16:
label:42'0 ~
17: GS-PACRET: non-protected ret found in function f_intermediate_overwrite1, basic block .Ltmp1, at address 10290
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
label:42'1 ? possible intended match
18: The return instruction is 00010290: ret
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
19: The 1 instructions that write to the return register after any authentication are:
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
20: 1. 0001028c: ldp x29, x30, [sp], #0x10
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
21: This happens in the following basic block:
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
22: 00010284: add x0, x0, #0x3
label:42'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.
.
.
>>>>>>
--
********************
********************
Failed Tests (1):
BOLT :: binary-analysis/AArch64/gs-pacret-autiasp.s
Testing Time: 23.89s
Total Discovered Tests: 518
Skipped : 7 (1.35%)
Unsupported : 40 (7.72%)
Passed : 469 (90.54%)
Expectedly Failed: 1 (0.19%)
Failed : 1 (0.19%)
```
https://github.com/llvm/llvm-project/pull/128565
More information about the llvm-commits
mailing list