[llvm] [BOLT][binary-analysis] Add initial pac-ret gadget scanner (PR #122304)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 12:13:53 PST 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-nfc` running on `bolt-worker` while building `bolt` at step 8 "test-build-bolt-check-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/92/builds/14125

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 8 (test-build-bolt-check-bolt) failure: test (failure)
******************** TEST 'BOLT :: binary-analysis/AArch64/gs-pacret-autiasp.s' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/clang  --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -march=armv9.5-a+pauth-lr -mbranch-protection=pac-ret /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/clang --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -march=armv9.5-a+pauth-lr -mbranch-protection=pac-ret /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
ld.lld: warning: cannot find entry symbol _start; not setting start address
RUN: at line 2: /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis --scanners=pacret /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis --scanners=pacret /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/gs-pacret-autiasp.s.tmp.exe
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s
/home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s:16:17: error: CHECK-LABEL: expected string not found in input
// CHECK-LABEL: GS-PACRET: non-protected ret found in function f1, basic block .LBB{{[0-9]+}}, at address
                ^
<stdin>:1:1: note: scanning from here
BOLT-INFO: shared object or position-independent executable detected
^
<stdin>:8:1: note: possible intended match here
GS-PACRET: non-protected ret found in function f1, basic block .Ltmp0, at address 10270
^

Input file: <stdin>
Check file: /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/gs-pacret-autiasp.s

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: BOLT-INFO: shared object or position-independent executable detected 
label:16'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: BOLT-INFO: Target architecture: aarch64 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: BOLT-INFO: BOLT version: 850b49297615a613ac83adca2c9cf823a4b8ef95 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: BOLT-INFO: first alloc address is 0x0 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            5: BOLT-INFO: creating new program header table at address 0x200000, offset 0x200000 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            6: BOLT-WARNING: non-relocation mode for AArch64 is not fully supported 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            7:  
label:16'0     ~
            8: GS-PACRET: non-protected ret found in function f1, basic block .Ltmp0, at address 10270 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
label:16'1     ?                                                                                        possible intended match
            9:  The return instruction is 00010270: ret 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           10:  The 1 instructions that write to the return register after any authentication are: 
label:16'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           11:  1. 0001026c: ldp x29, x30, [sp], #0x10 
...
Step 12 (nfc-check-bolt) failure: NFC check-bolt completed (failure)
******************** TEST 'BOLT :: binary-analysis/AArch64/cmdline-args.test' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 6: not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NOFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NOFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
RUN: at line 10: not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis non-existing-file 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NONEXISTINGFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NONEXISTINGFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis non-existing-file
RUN: at line 13: not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/Inputs/dummy.txt 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NOELFFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ not /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/Inputs/dummy.txt
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=NOELFFILEARG /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
RUN: at line 16: /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/clang  --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -Wl,--emit-relocs /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_foo.s /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/cmdline-args.test.tmp.exe
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/clang --target=x86_64-unknown-linux-gnu -fPIE -fuse-ld=lld -Wl,--unresolved-symbols=ignore-all -Wl,--build-id=none -pie --target=aarch64-linux-gnu -nostartfiles -nostdlib -ffreestanding -Wl,--emit-relocs /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_foo.s /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/../../Inputs/asm_main.c -o /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/cmdline-args.test.tmp.exe
ld.lld: warning: cannot find entry symbol _start; not setting start address
RUN: at line 17: /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/cmdline-args.test.tmp.exe 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=VALIDELFFILEARG --allow-empty /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/test/binary-analysis/AArch64/Output/cmdline-args.test.tmp.exe
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=VALIDELFFILEARG --allow-empty /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
RUN: at line 25: /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis --help 2>&1 | /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=HELP /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/llvm-bolt-binary-analysis --help
+ /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/bin/FileCheck -check-prefix=HELP /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test
/home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test:33:12: error: HELP-NEXT: is not on the line after the previous match
HELP-NEXT: Generic Options:
           ^
<stdin>:13:1: note: 'next' match was here
Generic Options:
^
<stdin>:6:1: note: previous match ended here

^
<stdin>:7:1: note: non-matching line after previous match is here
BinaryAnalysis options:
^

Input file: <stdin>
Check file: /home/worker/bolt-worker2/llvm-project/bolt/test/binary-analysis/AArch64/cmdline-args.test

-dump-input=help explains the following input dump.

Input was:
<<<<<<
         .
         .
         .
         8:  
         9:  --scanners=<value> - which gadget scanners to run 
        10:  =pacret - pac-ret 
        11:  =all - all 
...

```

</details>

https://github.com/llvm/llvm-project/pull/122304

More information about the llvm-commits mailing list