[llvm] Refactored verbosity flag in mlgo-utils to common location #107898 (PR #128541)
Mircea Trofin via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 10:28:49 PST 2025
================
----------------
mtrofin wrote:
nit: can you rename this to `flags` or `tool_flags` (open to other suggestions):
- we only use the `_lib` naming pattern when we have a tool and want to unittest it, so most of the tool logic is moved to the `_lib`, leaving the tool itself be basically the `main`
- an advantage of your patch is that it encapsulates the dependency on a specific arg parsing library (argparse), so renaming it away from what it encapsulates and towards what it provides its users makes sense, imho.
Thanks!
https://github.com/llvm/llvm-project/pull/128541
More information about the llvm-commits
mailing list