[llvm] Obviously Redundant Assert In AsmWriter (PR #128543)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-ir

Author: JP Hafer (jph-13)

<details>
<summary>Changes</summary>

The assert in GetConstant checks if Bound is constant.  However, GetConstant is only called when IsConstant==true.


---
Full diff: https://github.com/llvm/llvm-project/pull/128543.diff


1 Files Affected:

- (modified) llvm/lib/IR/AsmWriter.cpp (-1) 


``````````diff
diff --git a/llvm/lib/IR/AsmWriter.cpp b/llvm/lib/IR/AsmWriter.cpp
index 57e9cccdc0fb6..233b16f7f6856 100644
--- a/llvm/lib/IR/AsmWriter.cpp
+++ b/llvm/lib/IR/AsmWriter.cpp
@@ -2109,7 +2109,6 @@ static void writeDIGenericSubrange(raw_ostream &Out, const DIGenericSubrange *N,
   };
 
   auto GetConstant = [&](Metadata *Bound) -> int64_t {
-    assert(IsConstant(Bound) && "Expected constant");
     auto *BE = dyn_cast_or_null<DIExpression>(Bound);
     return static_cast<int64_t>(BE->getElement(1));
   };

``````````

</details>


https://github.com/llvm/llvm-project/pull/128543