[llvm] [LivePhysReg] Fix off by 1 error in an assert. NFC (PR #128379)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 22 15:37:42 PST 2025


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/128379

Pretty sure Reg should not be equal to the number of registers.

>From b25364fc2fb182fab2fa52af0fe2dc8acee14d37 Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Sat, 22 Feb 2025 15:36:43 -0800
Subject: [PATCH] [LivePhysReg] Fix off by 1 error in an assert. NFC

Pretty sure Reg should not be equal to the number of registers.
---
 llvm/include/llvm/CodeGen/LivePhysRegs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/include/llvm/CodeGen/LivePhysRegs.h b/llvm/include/llvm/CodeGen/LivePhysRegs.h
index 037905119eb22..696e8a0c5dd59 100644
--- a/llvm/include/llvm/CodeGen/LivePhysRegs.h
+++ b/llvm/include/llvm/CodeGen/LivePhysRegs.h
@@ -82,7 +82,7 @@ class LivePhysRegs {
   /// Adds a physical register and all its sub-registers to the set.
   void addReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCPhysReg SubReg : TRI->subregs_inclusive(Reg))
       LiveRegs.insert(SubReg);
   }
@@ -91,7 +91,7 @@ class LivePhysRegs {
   /// super-registers from the set.
   void removeReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCRegAliasIterator R(Reg, TRI, true); R.isValid(); ++R)
       LiveRegs.erase((*R).id());
   }



More information about the llvm-commits mailing list