[llvm] [llvm] DLLExport public methods from SmallVector (PR #127850)
Andrew Rogers via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 20 11:38:05 PST 2025
andrurogerz wrote:
> Can you collapse all the Support changes into a single PR and the set of changes for ADT into a single PR?
@compnerd I will batch these PRs per library. I apologize for the noise. Are you OK with merging batches of annotation changes before a library has been entirely annotated? Or would you prefer I hold-off on PRs until each library is complete? The latter will be more challenging since "complete" is a bit of a moving target, and I'll need to maintain a set of outstanding patches over multiple weeks until everything builds properly.
> Having these discussion linked in the PR description would provide very valuable context. I realized they are linked in the referenced issue, but that's an extra layer of indirection that made me miss those RFCs.
@kuhar Thank you for the feedback. I will directly reference RFCs and prior art in my future PRs for this work.
https://github.com/llvm/llvm-project/pull/127850
More information about the llvm-commits
mailing list