[llvm] [RISCV] [MachineOutliner] Analyze all candidates (PR #127659)

[Sudharsan Veeravalli via llvm-commits]

================
@@ -3015,30 +3015,25 @@ static bool cannotInsertTailCall(const MachineBasicBlock &MBB) {
   return false;
 }
 
-static std::optional<MachineOutlinerConstructionID>
-analyzeCandidate(outliner::Candidate &C) {
+static bool analyzeCandidate(outliner::Candidate &C) {
   // If last instruction is return then we can rely on
   // the verification already performed in the getOutliningTypeImpl.
   if (C.back().isReturn()) {
     assert(!cannotInsertTailCall(*C.getMBB()) &&
            "The candidate who uses return instruction must be outlined "
            "using tail call");
-    return MachineOutlinerTailCall;
+    return false;
   }
----------------
svs-quic wrote:

The sequences ending in return will be outlined as tail calls and the x5 checks are not a problem for this case. Also most of the checks for the MBBs ending in a return are handled in `cannotInsertTailCall` before we reach this function.

https://github.com/llvm/llvm-project/pull/127659