[llvm] [AArch64] Add support for SHF_AARCH64_PURECODE ELF section flag (1/3) (PR #125687)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 08:11:27 PST 2025


=?utf-8?q?Csanád_Hajdú?= <csanad.hajdu at arm.com>,
=?utf-8?q?Csanád_Hajdú?= <csanad.hajdu at arm.com>,
=?utf-8?q?Csanád_Hajdú?= <csanad.hajdu at arm.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/125687 at github.com>


================
@@ -559,9 +559,12 @@ static unsigned getELFSectionFlags(SectionKind K) {
   if (K.isText())
     Flags |= ELF::SHF_EXECINSTR;
 
-  if (K.isExecuteOnly())
+  if ((T.isARM() || T.isThumb()) && K.isExecuteOnly())
----------------
smithp35 wrote:

Could write this as
```
if (K.isExecuteOnly()) {
  if (T.isAArch64())
    Flags |= ELF::SHF_AARCH64_PURECODE;
  else if (T.isARM() || T.isThumb())
    Flags |= ELF::SHF_ARM_PURECODE;
}
```
To save some effort for the non isExecuteOnly case, but there's not much in it.

This is subjective on my part, so feel free to keep your original if you prefer.

https://github.com/llvm/llvm-project/pull/125687


More information about the llvm-commits mailing list