[llvm] [AArch64][Build Attributes] Remove assertion (PR #126530)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-aarch64

Author: SivanShani-Arm (sivan-shani)

<details>
<summary>Changes</summary>

When adding build attributes from assembly, an existing value should not trigger an assertion. This case is valid, and behavior should remain consistent between builds with and without assertions.

---
Full diff: https://github.com/llvm/llvm-project/pull/126530.diff


2 Files Affected:

- (modified) llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp (+2-6) 
- (added) tests.sh (+11) 


``````````diff
diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 1ed4a81a9767390..d4081e606448b4b 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -222,13 +222,9 @@ void AArch64TargetStreamer::emitAttribute(StringRef VendorName, unsigned Tag,
                      "Can not add AArch64 build attribute: An attribute with "
                      "the same tag and a different value already exists");
               return;
-            } else {
-              // Case Item.IntValue == Value, no need to emit twice
-              assert(0 &&
-                     "AArch64 build attribute: An attribute with the same tag "
-                     "and a same value already exists");
-              return;
             }
+            // Case Item.IntValue == Value, no need to emit twice
+            return;
           }
         }
       }
diff --git a/tests.sh b/tests.sh
new file mode 100755
index 000000000000000..182932267a6cdbf
--- /dev/null
+++ b/tests.sh
@@ -0,0 +1,11 @@
+${binrl}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+${binral}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+${bindl}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+
+${binrl}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+${binral}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+${bindl}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+
+${binrl}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*
+${binral}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*
+${bindl}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*

``````````

</details>


https://github.com/llvm/llvm-project/pull/126530