[llvm] [AArch64][Build Attributes] Remove assertion (PR #126530)

[via llvm-commits]

https://github.com/sivan-shani created https://github.com/llvm/llvm-project/pull/126530

When adding build attributes from assembly, an existing value should not trigger an assertion. This case is valid, and behavior should remain consistent between builds with and without assertions.

>From 982b60abb6429880e9e4f17de028aaf3c05d4b21 Mon Sep 17 00:00:00 2001
From: Sivan Shani <sivan.shani at arm.com>
Date: Mon, 10 Feb 2025 15:04:50 +0000
Subject: [PATCH] [AArch64][Build Attributes] Remove assertion

When adding build attributes from assembly, an existing value should not
trigger an assertion. This case is valid, and behavior should remain
consistent between builds with and without assertions.
---
 .../AArch64/MCTargetDesc/AArch64TargetStreamer.cpp    |  8 ++------
 tests.sh                                              | 11 +++++++++++
 2 files changed, 13 insertions(+), 6 deletions(-)
 create mode 100755 tests.sh

diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 1ed4a81a9767390..d4081e606448b4b 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -222,13 +222,9 @@ void AArch64TargetStreamer::emitAttribute(StringRef VendorName, unsigned Tag,
                      "Can not add AArch64 build attribute: An attribute with "
                      "the same tag and a different value already exists");
               return;
-            } else {
-              // Case Item.IntValue == Value, no need to emit twice
-              assert(0 &&
-                     "AArch64 build attribute: An attribute with the same tag "
-                     "and a same value already exists");
-              return;
             }
+            // Case Item.IntValue == Value, no need to emit twice
+            return;
           }
         }
       }
diff --git a/tests.sh b/tests.sh
new file mode 100755
index 000000000000000..182932267a6cdbf
--- /dev/null
+++ b/tests.sh
@@ -0,0 +1,11 @@
+${binrl}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+${binral}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+${bindl}/llvm-lit -v llvm/test/MC/AArch64/aarch64-build-attributes-asm-*
+
+${binrl}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+${binral}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+${bindl}/llvm-lit -v  llvm/test/CodeGen/AArch64/aarch64-build-attributes-*
+
+${binrl}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*
+${binral}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*
+${bindl}/llvm-lit -v  /home/sivsha01/Repos/llvm-project/llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-build-attributes-*