[llvm] [TableGen] Split DAGISelMatcherOpt FactorNodes into 2 functions. NFC (PR #125330)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 2 19:35:49 PST 2025


================
@@ -492,6 +480,20 @@ static void FactorNodes(std::unique_ptr<Matcher> &InputMatcherPtr) {
     Scope->resetChild(i, OptionsToMatch[i]);
 }
 
+/// Search a ScopeMatcher to factor with FactorScope.
+static void FactorNodes(std::unique_ptr<Matcher> &InputMatcherPtr) {
----------------
arsenm wrote:

I don't see why this is referencing unique_ptr at all. This could be done in terms of Matcher* or Matcher& 

https://github.com/llvm/llvm-project/pull/125330


More information about the llvm-commits mailing list