[llvm] 8266eed - [SandboxIR] Avoid repeated hash lookups (NFC) (#125337)

via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 1 08:14:42 PST 2025


Author: Kazu Hirata
Date: 2025-02-01T08:14:39-08:00
New Revision: 8266eedfdccddfc8901679ee55e358793e29bba5

URL: https://github.com/llvm/llvm-project/commit/8266eedfdccddfc8901679ee55e358793e29bba5
DIFF: https://github.com/llvm/llvm-project/commit/8266eedfdccddfc8901679ee55e358793e29bba5.diff

LOG: [SandboxIR] Avoid repeated hash lookups (NFC) (#125337)

Added: 
    

Modified: 
    llvm/lib/SandboxIR/Region.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/SandboxIR/Region.cpp b/llvm/lib/SandboxIR/Region.cpp
index 8c84d0c46fa10a..dbb000e5dd9253 100644
--- a/llvm/lib/SandboxIR/Region.cpp
+++ b/llvm/lib/SandboxIR/Region.cpp
@@ -94,16 +94,12 @@ Region::createRegionsFromMD(Function &F, TargetTransformInfo &TTI) {
   for (BasicBlock &BB : F) {
     for (Instruction &Inst : BB) {
       if (auto *MDN = cast<llvm::Instruction>(Inst.Val)->getMetadata(MDKind)) {
-        Region *R = nullptr;
-        auto It = MDNToRegion.find(MDN);
-        if (It == MDNToRegion.end()) {
+        auto [It, Inserted] = MDNToRegion.try_emplace(MDN);
+        if (Inserted) {
           Regions.push_back(std::make_unique<Region>(Ctx, TTI));
-          R = Regions.back().get();
-          MDNToRegion[MDN] = R;
-        } else {
-          R = It->second;
+          It->second = Regions.back().get();
         }
-        R->add(&Inst);
+        It->second->add(&Inst);
       }
     }
   }


        


More information about the llvm-commits mailing list