[llvm] c641c1a - [VPlan] Pass VPValue operands to handleReplication. (NFC)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 31 14:02:02 PST 2025
Author: Florian Hahn
Date: 2025-01-31T22:00:28Z
New Revision: c641c1aace9ce5bc307bdf9479d10f108505755e
URL: https://github.com/llvm/llvm-project/commit/c641c1aace9ce5bc307bdf9479d10f108505755e
DIFF: https://github.com/llvm/llvm-project/commit/c641c1aace9ce5bc307bdf9479d10f108505755e.diff
LOG: [VPlan] Pass VPValue operands to handleReplication. (NFC)
Update handleReplication to also take VPValue operands as argument, in
line with the other methods in VPRecipeBuilder.
Added:
Modified:
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 493ce848171211..0ffd70c8544b1d 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -8628,8 +8628,9 @@ void VPRecipeBuilder::fixHeaderPhis() {
}
}
-VPReplicateRecipe *VPRecipeBuilder::handleReplication(Instruction *I,
- VFRange &Range) {
+VPReplicateRecipe *
+VPRecipeBuilder::handleReplication(Instruction *I, ArrayRef<VPValue *> Operands,
+ VFRange &Range) {
bool IsUniform = LoopVectorizationPlanner::getDecisionAndClampRange(
[&](ElementCount VF) { return CM.isUniformAfterVectorization(I, VF); },
Range);
@@ -8685,8 +8686,8 @@ VPReplicateRecipe *VPRecipeBuilder::handleReplication(Instruction *I,
assert((Range.Start.isScalar() || !IsUniform || !IsPredicated ||
(Range.Start.isScalable() && isa<IntrinsicInst>(I))) &&
"Should not predicate a uniform recipe");
- auto *Recipe = new VPReplicateRecipe(I, mapToVPValues(I->operands()),
- IsUniform, BlockInMask);
+ auto *Recipe = new VPReplicateRecipe(
+ I, make_range(Operands.begin(), Operands.end()), IsUniform, BlockInMask);
return Recipe;
}
@@ -9358,7 +9359,7 @@ LoopVectorizationPlanner::tryToBuildVPlanWithVPRecipes(VFRange &Range) {
VPRecipeBase *Recipe =
RecipeBuilder.tryToCreateWidenRecipe(Instr, Operands, Range, VPBB);
if (!Recipe)
- Recipe = RecipeBuilder.handleReplication(Instr, Range);
+ Recipe = RecipeBuilder.handleReplication(Instr, Operands, Range);
RecipeBuilder.setRecipe(Instr, Recipe);
if (isa<VPHeaderPHIRecipe>(Recipe)) {
diff --git a/llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h b/llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
index 87c97d1edd7b6a..fdaa63b0ba4f30 100644
--- a/llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
+++ b/llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
@@ -218,10 +218,12 @@ class VPRecipeBuilder {
return Ingredient2Recipe[I];
}
- /// Build a VPReplicationRecipe for \p I. If it is predicated, add the mask as
- /// last operand. Range.End may be decreased to ensure same recipe behavior
- /// from \p Range.Start to \p Range.End.
- VPReplicateRecipe *handleReplication(Instruction *I, VFRange &Range);
+ /// Build a VPReplicationRecipe for \p I using \p Operands. If it is
+ /// predicated, add the mask as last operand. Range.End may be decreased to
+ /// ensure same recipe behavior from \p Range.Start to \p Range.End.
+ VPReplicateRecipe *handleReplication(Instruction *I,
+ ArrayRef<VPValue *> Operands,
+ VFRange &Range);
/// Add the incoming values from the backedge to reduction & first-order
/// recurrence cross-iteration phis.
More information about the llvm-commits
mailing list