[llvm] [TRANSFORMS][SUPPORT] Added const reference for params with size >= 16 bytes (PR #125085)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 20:11:15 PST 2025


================
@@ -109,15 +109,15 @@ class BinaryStreamWriter {
   ///
   /// \returns a success error code if the data was successfully written,
   /// otherwise returns an appropriate error code.
-  Error writeStreamRef(BinaryStreamRef Ref);
+  Error writeStreamRef(const BinaryStreamRef &Ref);
----------------
arsenm wrote:

The Ref seems to indicate this was intended to be passed by value. I assume this is 16-size? I would expect the minimum threshold to be at least > 16, not >= 16 

https://github.com/llvm/llvm-project/pull/125085


More information about the llvm-commits mailing list