[llvm] [DXIL] Adding support to RootSignatureFlags in obj2yaml (PR #122396)

Damyan Pepper via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 16:57:00 PST 2025


damyanp wrote:

I'm wondering how we have confidence that this is reading/writing correctly formatted data?  It looks to me like the current tests are validating that yaml->binary and binary->yaml work correctly, but there's nothing validating that the binary part is correct?

Am I missing something?  Maybe this is done elsewhere?

I see in llvm/unittests/Object/DXContainerTest.cpp that there's tests that check that binary data (dxc is probably the easiest way to generate this) works correctly.  Should there be something like this here?


https://github.com/llvm/llvm-project/pull/122396


More information about the llvm-commits mailing list