[llvm] [llvm-objdump] Add support for HIP offload bundles (PR #114834)
Yaxun Liu via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 30 09:26:42 PST 2025
yxsamliu wrote:
> I'm wondering if we should split up the addition of the offloading binary handling. How different are the definitions here from the ones in `clang/Driver/OffloadBundler.h`? Should we just move those to LLVM? I also feel like the definitions should be in a separate header file, since they're distinct from the `OffloadBinary`, totally different binary formats.
I tend to agree that it is cleaner to have separate header and cpp files for OffloadBundler in LLVM, but we could defer the refactoring of clang code to another PR as David suggested in the reply to one of my previous comments.
https://github.com/llvm/llvm-project/pull/114834
More information about the llvm-commits
mailing list