[llvm] [DirectX] Set Shader Flag DisableOptimizations. (PR #123136)

[S. Bharadwaj Yadavalli via llvm-commits]

bharadwajy wrote:

>  [...] It also isn't clear to me how this will interact with linking - what if part of the module is built with optimizations disabled and part with them enabled? Reconciling global metadata in this case sounds like a nightmare, whereas the `optnone` attribute that is already present on functions will already do the right thing.

With the changes that delete the metadata `dx.disable_optimizations`, the only thing a DXIL linker would rely on to know if optimizations were disabled during compilation of modules being linked is the documented (and generated) shader flag `DisableOptimizations`. I believe DXC linking rules have a (some?) solution for this or we may have to revisit them for the ongoing HLSL support for HLSL, irrespective of the mechanism to set the shader flag `DisableOptimizations`.


https://github.com/llvm/llvm-project/pull/123136