[lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

[David Spickett via llvm-commits]

https://github.com/DavidSpickett approved this pull request.

We're hitting limitations in Windows itself, and 1 watchpoint is more useful than zero, so this LGTM.

To preempt a potential discussion: I think this should not be backported to 20. Unless you've got a very good reason for it. We don't have the most comprehensive testing on Windows and we already have a few caveats here. We might encounter more as time goes on and fixes may be complex.

But, by LLDB 21, maybe we will have ironed those out.

https://github.com/llvm/llvm-project/pull/108072