[llvm] [CodeGen] Avoid repeated hash lookups (NFC) (PR #125025)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 20:19:55 PST 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/125025
None
>From 262c6e8152fa3ce5ace606070651afd00e7b8080 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 29 Jan 2025 08:53:37 -0800
Subject: [PATCH] [CodeGen] Avoid repeated hash lookups (NFC)
---
llvm/lib/CodeGen/StackColoring.cpp | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/CodeGen/StackColoring.cpp b/llvm/lib/CodeGen/StackColoring.cpp
index b77b8dbdd6e595..27c65d234a618c 100644
--- a/llvm/lib/CodeGen/StackColoring.cpp
+++ b/llvm/lib/CodeGen/StackColoring.cpp
@@ -914,10 +914,10 @@ void StackColoring::remapInstructions(DenseMap<int, int> &SlotRemap) {
if (!VI.Var || !VI.inStackSlot())
continue;
int Slot = VI.getStackSlot();
- if (SlotRemap.count(Slot)) {
+ if (auto It = SlotRemap.find(Slot); It != SlotRemap.end()) {
LLVM_DEBUG(dbgs() << "Remapping debug info for ["
<< cast<DILocalVariable>(VI.Var)->getName() << "].\n");
- VI.updateStackSlot(SlotRemap[Slot]);
+ VI.updateStackSlot(It->second);
FixedDbg++;
}
}
@@ -1004,10 +1004,11 @@ void StackColoring::remapInstructions(DenseMap<int, int> &SlotRemap) {
if (!AI)
continue;
- if (!Allocas.count(AI))
+ auto It = Allocas.find(AI);
+ if (It == Allocas.end())
continue;
- MMO->setValue(Allocas[AI]);
+ MMO->setValue(It->second);
FixedMemOp++;
}
@@ -1173,8 +1174,8 @@ void StackColoring::expungeSlotMap(DenseMap<int, int> &SlotRemap,
// Expunge slot remap map.
for (unsigned i=0; i < NumSlots; ++i) {
// If we are remapping i
- if (SlotRemap.count(i)) {
- int Target = SlotRemap[i];
+ if (auto It = SlotRemap.find(i); It != SlotRemap.end()) {
+ int Target = It->second;
// As long as our target is mapped to something else, follow it.
while (SlotRemap.count(Target)) {
Target = SlotRemap[Target];
More information about the llvm-commits
mailing list