[clang] [llvm] [llvm] Enable TLSDESC by default on Fuchsia targets (PR #124990)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 13:32:15 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-driver
Author: Paul Kirth (ilovepi)
<details>
<summary>Changes</summary>
Fuchsia uses TLSDESC by default for all target architectures.
---
Full diff: https://github.com/llvm/llvm-project/pull/124990.diff
2 Files Affected:
- (modified) clang/test/Driver/tls-dialect.c (+5)
- (modified) llvm/include/llvm/TargetParser/Triple.h (+3-1)
``````````diff
diff --git a/clang/test/Driver/tls-dialect.c b/clang/test/Driver/tls-dialect.c
index 3471b55b0ebae9..9ab79e87353d88 100644
--- a/clang/test/Driver/tls-dialect.c
+++ b/clang/test/Driver/tls-dialect.c
@@ -10,6 +10,11 @@
/// TLSDESC is not on by default in Linux, even on RISC-V, and is covered above
// RUN: %clang -### --target=riscv64-android %s 2>&1 | FileCheck --check-prefix=DESC %s
+/// Fuchsia supports TLSDESC by default for all architectures.
+// RUN: %clang -### --target=riscv64-unknown-fuchsia %s 2>&1 | FileCheck --check-prefix=DESC %s
+// RUN: %clang -### --target=aarch64-unknown-fuchsia %s 2>&1 | FileCheck --check-prefix=DESC %s
+// RUN: %clang -### --target=x86_64-unknown-fuchsia %s 2>&1 | FileCheck --check-prefix=DESC %s
+
/// LTO
// RUN: %clang -### --target=loongarch64-linux -flto -mtls-dialect=desc %s 2>&1 | FileCheck --check-prefix=LTO-DESC %s
// RUN: %clang -### --target=loongarch64-linux -flto %s 2>&1 | FileCheck --check-prefix=LTO-NODESC %s
diff --git a/llvm/include/llvm/TargetParser/Triple.h b/llvm/include/llvm/TargetParser/Triple.h
index 8097300c6e630c..6afc6ec974ca72 100644
--- a/llvm/include/llvm/TargetParser/Triple.h
+++ b/llvm/include/llvm/TargetParser/Triple.h
@@ -1119,7 +1119,9 @@ class Triple {
/// True if the target supports both general-dynamic and TLSDESC, and TLSDESC
/// is enabled by default.
- bool hasDefaultTLSDESC() const { return isAndroid() && isRISCV64(); }
+ bool hasDefaultTLSDESC() const {
+ return (isAndroid() && isRISCV64()) || isOSFuchsia();
+ }
/// Tests whether the target uses -data-sections as default.
bool hasDefaultDataSections() const {
``````````
</details>
https://github.com/llvm/llvm-project/pull/124990
More information about the llvm-commits
mailing list