[llvm] [GitHub] Add workflows to manage merging of PRs from authors without commit access (PR #124910)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 12:56:43 PST 2025


nikic wrote:

> > It should be enough to just add comment asking for someone to commit the PR after it's been reviewed.
> 
> This seems to just get us back to the original spot where the PR author needs to know our processes in order to get something merge? It's not too different from just asking them to ping the reviewers asking them to merge (from what I'm understanding).

It's different in that the PR author doesn't have to do it. Automation will remind the reviewer that the PR needs merging after it has been approved.

And I agree with @tstellar that I'd prefer that over the more involved process proposed here.

I think the only thing I'd suggest is to delay that comment until all CI workflows on the PR have completed (either success or fail). Otherwise I have to remember to come back to the PR after CI is finished.

https://github.com/llvm/llvm-project/pull/124910


More information about the llvm-commits mailing list