[llvm] [GitHub] Add workflows to manage merging of PRs from authors without commit access (PR #124910)
David Spickett via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 29 06:50:49 PST 2025
DavidSpickett wrote:
> Manually adding requires authors and/or reviewers to know they have to do it, and documentation is hard in this case because it's "elsewhere".
Yes, if this went into production I think it would have to be with documentation on the website about how it works. For approvers mostly, an author should just know that there is a process that will help them.
> Another corner case is removing the tag and warning me but I miss the ping (lost in emails, crash browser) and then the state is lost.
> How about we have two tags: no-commit-access and ready-to-merge?
Yes, or the approvers could just disappear, as do some authors. So a second label would let us proactively query PRs to find something in this state.
The idea with removing the tag at the end was so that we do not look at that PR again while it remains open, but I can do the same thing with 2 tags. If you have no-commit-access, then we check the PR, if you have both tags, we ignore the PR, on the assumption that everything is in hand.
> Workflow:
I should have written it out in pseudocode too :) I'll do that for the next update.
I think formatting jobs trigger on branch update, so I can extend that to remove a label if needed.
https://github.com/llvm/llvm-project/pull/124910
More information about the llvm-commits
mailing list