[compiler-rt] [Apple][RTSan] Realtime sanitizers are failing in Apple CI (PR #124873)

[Chris Apple via llvm-commits]

================
@@ -1037,18 +1037,18 @@ TEST(TestRtsanInterceptors, PthreadJoinDiesWhenRealtime) {
 
 #if SANITIZER_APPLE
 
-#pragma clang diagnostic push
-// OSSpinLockLock is deprecated, but still in use in libc++
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-TEST(TestRtsanInterceptors, OsSpinLockLockDiesWhenRealtime) {
-  auto Func = []() {
-    OSSpinLock spin_lock{};
-    OSSpinLockLock(&spin_lock);
-  };
-  ExpectRealtimeDeath(Func, "OSSpinLockLock");
-  ExpectNonRealtimeSurvival(Func);
-}
-#pragma clang diagnostic pop
+// #pragma clang diagnostic push
+// // OSSpinLockLock is deprecated, but still in use in libc++
+// #pragma clang diagnostic ignored "-Wdeprecated-declarations"
+// TEST(TestRtsanInterceptors, OsSpinLockLockDiesWhenRealtime) {
----------------
cjappl wrote:

For this test, is it possible that your internal build of MacOS completely killed off OsSpinLock, and this call no longer does anything? That's my very naive hunch seeing as it's wrapped in in `-Wno-deprecated-declarations`

https://github.com/llvm/llvm-project/pull/124873