[llvm] [GVN] Load-store forwaring of scalable store to fixed load. (PR #124748)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 07:16:56 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff c0861e9cbbc3b342e49a8688cdc15aa7c8e9f29a e39959470dcd003fbf232b9e6b2beec45d659b82 --extensions h,cpp -- llvm/include/llvm/Transforms/Utils/VNCoercion.h llvm/lib/Transforms/Scalar/GVN.cpp llvm/lib/Transforms/Utils/VNCoercion.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp
index 9c9d8f328f..3f306bb52c 100644
--- a/llvm/lib/Transforms/Scalar/GVN.cpp
+++ b/llvm/lib/Transforms/Scalar/GVN.cpp
@@ -1109,7 +1109,8 @@ Value *AvailableValue::MaterializeAdjustedValue(LoadInst *Load,
Res = CoercedLoad;
combineMetadataForCSE(CoercedLoad, Load, false);
} else {
- Res = getValueForLoad(CoercedLoad, Offset, LoadTy, InsertPt, Load->getFunction());
+ Res = getValueForLoad(CoercedLoad, Offset, LoadTy, InsertPt,
+ Load->getFunction());
// We are adding a new user for this load, for which the original
// metadata may not hold. Additionally, the new load may have a different
// size and type, so their metadata cannot be combined in any
diff --git a/llvm/lib/Transforms/Utils/VNCoercion.cpp b/llvm/lib/Transforms/Utils/VNCoercion.cpp
index b4b7379212..847311171b 100644
--- a/llvm/lib/Transforms/Utils/VNCoercion.cpp
+++ b/llvm/lib/Transforms/Utils/VNCoercion.cpp
@@ -96,8 +96,7 @@ bool canCoerceMustAliasedValueToLoad(Value *StoredVal, Type *LoadTy,
///
/// If we can't do it, return null.
Value *coerceAvailableValueToLoadType(Value *StoredVal, Type *LoadedTy,
- IRBuilderBase &Helper,
- Function *F) {
+ IRBuilderBase &Helper, Function *F) {
assert(canCoerceMustAliasedValueToLoad(StoredVal, LoadedTy, F) &&
"precondition violation - materialization can't fail");
const DataLayout &DL = F->getDataLayout();
@@ -450,8 +449,8 @@ Value *getMemInstValueForLoad(MemIntrinsic *SrcInst, unsigned Offset,
++NumBytesSet;
}
- return coerceAvailableValueToLoadType(
- Val, LoadTy, Builder, InsertPt->getFunction());
+ return coerceAvailableValueToLoadType(Val, LoadTy, Builder,
+ InsertPt->getFunction());
}
// Otherwise, this is a memcpy/memmove from a constant global.
``````````
</details>
https://github.com/llvm/llvm-project/pull/124748
More information about the llvm-commits
mailing list