[llvm] [AMDGPU] selecting v_sat_pk instruction, version 2 (PR #123297)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 00:55:05 PST 2025


================
@@ -823,6 +823,25 @@ SITargetLowering::SITargetLowering(const TargetMachine &TM,
                          {MVT::v4f32, MVT::v8f32, MVT::v16f32, MVT::v32f32},
                          Custom);
     }
+
+    // True 16 instruction is current not supported
+    // FIXME: Add support for true 16 when supported
+    if (!(Subtarget->hasTrue16BitInsts() && Subtarget->useRealTrue16Insts())) {
----------------
arsenm wrote:

I don't see how this is checking for the existence of the underlying instruction. Plus the negation should be pushed through the condition 

https://github.com/llvm/llvm-project/pull/123297


More information about the llvm-commits mailing list