[llvm] [ELFObject] Added dbgs() statement in removeSections() (PR #124692)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 00:24:05 PST 2025
https://github.com/jh7370 commented:
The symbols part of this looks reasonable to me, but I'm not sure what you've done with the Section part and there's a more obvious place for that change (see my inline comments).
Some other notes:
1) Make sure to write a test.
2) Don't use `dbgs()` to print things: use `llvm::outs()` (or `llvm::errs()`, depending on whether GNU strip prints to stdout or stderr), guarded by an `if (Verbose)` style check.
3) Don't forget to update the documentation.
https://github.com/llvm/llvm-project/pull/124692
More information about the llvm-commits
mailing list