[lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

[Orlando Cazalet-Hyams via llvm-commits]

================
@@ -1656,7 +1656,8 @@ static Value *emitSetAndGetSwiftErrorValueAround(Instruction *Call,
     Builder.SetInsertPoint(Call->getNextNode());
   } else {
     auto Invoke = cast<InvokeInst>(Call);
-    Builder.SetInsertPoint(Invoke->getNormalDest()->getFirstNonPHIOrDbg());
+    BasicBlock::iterator It = Invoke->getNormalDest()->getFirstNonPHIOrDbg();
+    Builder.SetInsertPoint(It);
----------------
OCHyams wrote:

Why is this change necessary?

https://github.com/llvm/llvm-project/pull/124287