[llvm] [NFC][DebugInfo] Switch more call-sites to using iterator-insertion (PR #124283)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 06:24:56 PST 2025


================
@@ -5449,7 +5448,7 @@ static bool removeEmptyCleanup(CleanupReturnInst *RI, DomTreeUpdater *DTU) {
     }
 
     // Sink any remaining PHI nodes directly into UnwindDest.
-    Instruction *InsertPt = DestEHPad;
+    BasicBlock::iterator InsertPt = UnwindDest->getFirstNonPHIIt(); // XXX unsafe faff
----------------
OCHyams wrote:

Comment leftover from development? And why is it unsafe?

https://github.com/llvm/llvm-project/pull/124283


More information about the llvm-commits mailing list