[llvm] [MachineScheduler] Fix physreg dependencies of ExitSU (PR #123541)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 19 22:37:58 PST 2025


================
@@ -263,6 +275,9 @@ void ScheduleDAGInstrs::addPhysRegDataDeps(SUnit *SU, unsigned OperIdx) {
       bool ImplicitPseudoUse = false;
       SDep Dep;
       if (UseOpIdx < 0) {
+        // FIXME: UseOpIdx can be passed to computeOperandLatency, which can
+        //   pass it to findUseIdx, which treats it as unsigned. If this is
+        //   the expected behavior, it should be commented.
----------------
s-barannikov wrote:

Should I reword the comment, perhaps? I think this still deserves a FIXME.


https://github.com/llvm/llvm-project/pull/123541


More information about the llvm-commits mailing list