[llvm] [CodeGen] Introduce Static Data Splitter pass (PR #122183)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 17:22:10 PST 2025


================
@@ -1291,6 +1291,10 @@ const unsigned MachineFunction::DebugOperandMemNumber = 1000000;
 //  MachineJumpTableInfo implementation
 //===----------------------------------------------------------------------===//
 
+MachineJumpTableEntry::MachineJumpTableEntry(
+    const std::vector<MachineBasicBlock *> &MBBs)
+    : MBBs(MBBs), Hotness(DataHotness::Unknown) {}
----------------
mingmingl-llvm wrote:

The constructor is moved here for coding style considerations in the specific [1] code paths. The code is written in a way that `MachineFunctionDataHotness` enum is declared in but not defined in header files, and only cpp files see its definition if needed (e.g., llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp uses this field in line 672 in the follow up patch)

[1] For CodeGen, its header directory has {MachineJumpTableInfo.h, MachineConstantPool.h. MachineFunction.h},  and `MachineFunction.cpp` defines functions that are declared in the three header files.




https://github.com/llvm/llvm-project/pull/122183


More information about the llvm-commits mailing list