[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

[Vitaly Buka via llvm-commits]

================
@@ -137,6 +137,10 @@ llvm::AllocaInst *CodeGenFunction::CreateTempAlloca(llvm::Type *Ty,
     Alloca =
         new llvm::AllocaInst(Ty, CGM.getDataLayout().getAllocaAddrSpace(),
                              ArraySize, Name, AllocaInsertPt->getIterator());
+  if (Alloca->getName() != Name.str() &&
----------------
vitalybuka wrote:

@efriedma-quic To clarify we do: 
1.  set metadata always
2. remove DiscardValueNames hack (in a different future patch please, as this may cause regressions if we loose metdata more often than name)

LGTM if https://llvm-compile-time-tracker.com/ fail to notice a difference

https://github.com/llvm/llvm-project/pull/119387