[llvm] [SLP] NFC. Use InstructionsState::valid if users just want to know whether VL has same opcode. (PR #120217)

[Paul Osmialowski via llvm-commits]

pawosm-arm wrote:

Not sure what command you need, check-llvm is a part of the testing I've invoked with `ninja check-all`. I presume the following would be more helpful for you:

```
clang++: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:821: llvm::Instruction* {anonymous}::InstructionsState::getMainOp() const: Assertion `valid() && "InstructionsState is invalid."' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iunittests/ADT -Illvm/unittests/ADT -Iinclude -Illvm/include -Ithird-party/unittest/googletest/include -Ithird-party/unittest/googlemock/include -D_LIBCPP_VERBOSE_ABORT_NOT_NOEXCEPT -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-param
eter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -f
diagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/ADT/CMakeFiles/ADTTests.dir/DenseMapTest.cpp.o -MF unittests/ADT/CMakeFiles/ADTTests.di
r/DenseMapTest.cpp.o.d -o unittests/ADT/CMakeFiles/ADTTests.dir/DenseMapTest.cpp.o -c llvm/unittests/ADT/DenseMapTest.cpp
1.      <eof> parser at end of file
2.      Optimizer
3.      Running pass "function<eager-inv>(float2int,lower-constant-intrinsics,chr,loop(loop-rotate<header-duplication;no-prepare-for-lto>,loop-deletion),loop-distribute,inject-tli-mappings,loop-vectorize<no-interleave-forced-only;no-vectorize-forced-only;>,infer-alignment,loop-load-elim,instcombine<max-iterations=1
;no-verify-fixpoint>,simplifycfg<bonus-inst-threshold=1;forward-switch-cond;switch-range-to-icmp;switch-to-lookup;no-keep-loops;hoist-common-insts;no-hoist-loads-stores-with-cond-faulting;sink-common-insts;speculate-blocks;simplify-cond-branch;no-speculate-unpredictables>,slp-vectorizer,vector-combine,instcombine<m
ax-iterations=1;no-verify-fixpoint>,loop-unroll<O3>,transform-warning,sroa<preserve-cfg>,infer-alignment,instcombine<max-iterations=1;no-verify-fixpoint>,loop-mssa(licm<allowspeculation>),alignment-from-assumptions,loop-sink,instsimplify,div-rem-pairs,tailcallelim,simplifycfg<bonus-inst-threshold=1;no-forward-switc
h-cond;switch-range-to-icmp;no-switch-to-lookup;keep-loops;no-hoist-common-insts;hoist-loads-stores-with-cond-faulting;no-sink-common-insts;speculate-blocks;simplify-cond-branch;speculate-unpredictables>)" on module "llvm/unittests/ADT/DenseMapTes
t.cpp"
4.      Running pass "slp-vectorizer" on function "_ZN12_GLOBAL__N_140DenseMapCustomTest_InitFromIterator_Test8TestBodyEv"
 #0 0x0000aaaad1577b64 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (bin/clang+++0x2227b64)
 #1 0x0000aaaad157558c llvm::sys::RunSignalHandlers() (bin/clang+++0x222558c)
 #2 0x0000aaaad14d28a4 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
 #3 0x0000ffffae1fb7dc (linux-vdso.so.1+0x7dc)
 #4 0x0000ffffadd7f200 __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
 #5 0x0000ffffadd3a67c gsignal ./signal/../sysdeps/posix/raise.c:27:6
 #6 0x0000ffffadd27130 abort ./stdlib/abort.c:81:7
 #7 0x0000ffffadd33fd0 __assert_fail_base ./assert/assert.c:89:7
 #8 0x0000ffffadd34040 __assert_perror_fail ./assert/assert-perr.c:31:1
 #9 0x0000aaaad2ea9c68 (bin/clang+++0x3b59c68)
#10 0x0000aaaad2f5ebd4 llvm::slpvectorizer::BoUpSLP::transformNodes() (bin/clang+++0x3c0ebd4)
#11 0x0000aaaad2f7cddc (anonymous namespace)::HorizontalReduction::tryToReduce(llvm::slpvectorizer::BoUpSLP&, llvm::DataLayout const&, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo const&, llvm::AssumptionCache*) SLPVectorizer.cpp:0:0
#12 0x0000aaaad2f7f988 llvm::SLPVectorizerPass::vectorizeHorReduction(llvm::PHINode*, llvm::Instruction*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&, llvm::SmallVectorImpl<llvm::WeakTrackingVH>&) (bin/clang+++0x3c2f988)
#13 0x0000aaaad2f83b84 llvm::SLPVectorizerPass::vectorizeRootInstruction(llvm::PHINode*, llvm::Instruction*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (.constprop.0) SLPVectorizer.cpp:0:0
#14 0x0000aaaad2f87184 llvm::SLPVectorizerPass::vectorizeChainsInBlock(llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (bin/clang+++0x3c37184)
#15 0x0000aaaad2f8caa4 llvm::SLPVectorizerPass::runImpl(llvm::Function&, llvm::ScalarEvolution*, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo*, llvm::AAResults*, llvm::LoopInfo*, llvm::DominatorTree*, llvm::AssumptionCache*, llvm::DemandedBits*, llvm::OptimizationRemarkEmitter*) (.part.0) SLPVectorizer.cpp:0
:0
```

https://github.com/llvm/llvm-project/pull/120217