[llvm] [MachineLICM] Recognize registers clobbered at EH landing pad entry (PR #122446)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 05:03:51 PST 2025


================
@@ -639,6 +639,21 @@ void MachineLICMImpl::HoistRegionPostRA(MachineLoop *CurLoop,
     if (const uint32_t *Mask = BB->getBeginClobberMask(TRI))
       applyBitsNotInRegMaskToRegUnitsMask(*TRI, RUClobbers, Mask);
 
+    // EH landing pads clobber exception pointer/selector registers
+    if (BB->isEHPad()) {
+      const MachineFunction &MF = *BB->getParent();
+      if (MF.getFunction().hasPersonalityFn()) {
+        auto PersonalityFn = MF.getFunction().getPersonalityFn();
+        const TargetLowering &TLI = *MF.getSubtarget().getTargetLowering();
+        if (unsigned Reg = TLI.getExceptionPointerRegister(PersonalityFn))
+          for (MCRegUnitIterator RUI(Reg, TRI); RUI.isValid(); ++RUI)
+            RUClobbers.set(*RUI);
+        if (unsigned Reg = TLI.getExceptionSelectorRegister(PersonalityFn))
+          for (MCRegUnitIterator RUI(Reg, TRI); RUI.isValid(); ++RUI)
+            RUClobbers.set(*RUI);
+      }
+    }
----------------
uweigand wrote:

They are not reserved, but they are callee saved.  That's why they're considered candidates to be hoisted even though there's a call in the loop.  And normally that would be fine except for the special EH landing pad case.

I'm not sure where else these should be handled, I simply noticed that several other places also handle these registers specially.

https://github.com/llvm/llvm-project/pull/122446


More information about the llvm-commits mailing list