[llvm] [SLP] NFC. Replace MainOp and AltOp in TreeEntry with InstructionsState. (PR #120198)

Thu Jan 9 21:56:59 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/15893

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
2.550 [10/38/432] Linking CXX static library /b/1/clang-x86_64-debian-fast/llvm.obj/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.memprof-preinit.a
2.554 [10/37/433] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_posix.cpp.o
2.558 [10/36/434] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingValue.c.o
2.566 [10/35/435] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.i386.dir/sanitizer_stack_store.cpp.o
2.570 [10/34/436] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_stack.cpp.o
2.575 [10/33/437] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_flags.cpp.o
2.577 [10/32/438] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.x86_64.dir/sanitizer_symbolizer_libcdep.cpp.o
2.583 [10/31/439] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_linux.cpp.o
2.585 [10/30/440] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_descriptions.cpp.o
2.595 [10/29/441] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o
FAILED: compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o 
/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/.. -I/b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/../../include -fPIC -fno-semantic-interposition -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m32 -fno-lto -fPIC -Wno-pedantic -DCOMPILER_RT_HAS_ATOMICS=1 -DCOMPILER_RT_HAS_FCNTL_LCK=1 -DCOMPILER_RT_HAS_FLOCK=1 -DCOMPILER_RT_HAS_UNAME=1 -nostdinc++ -MD -MT compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o -MF compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o.d -o compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o -c /b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/InstrProfilingFile.c
clang: /b/1/clang-x86_64-debian-fast/llvm.src/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:821: llvm::Instruction *(anonymous namespace)::InstructionsState::getMainOp() const: Assertion `valid() && "InstructionsState is invalid."' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang --target=x86_64-unknown-linux-gnu -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/.. -I/b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/../../include -fPIC -fno-semantic-interposition -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m32 -fno-lto -fPIC -Wno-pedantic -DCOMPILER_RT_HAS_ATOMICS=1 -DCOMPILER_RT_HAS_FCNTL_LCK=1 -DCOMPILER_RT_HAS_FLOCK=1 -DCOMPILER_RT_HAS_UNAME=1 -nostdinc++ -MD -MT compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o -MF compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o.d -o compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o -c /b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/InstrProfilingFile.c
1.	<eof> parser at end of file
2.	Optimizer
3.	Running pass "function<eager-inv>(float2int,lower-constant-intrinsics,chr,loop(loop-rotate<header-duplication;no-prepare-for-lto>,loop-deletion),loop-distribute,inject-tli-mappings,loop-vectorize<no-interleave-forced-only;no-vectorize-forced-only;>,infer-alignment,loop-load-elim,instcombine<max-iterations=1;no-verify-fixpoint>,simplifycfg<bonus-inst-threshold=1;forward-switch-cond;switch-range-to-icmp;switch-to-lookup;no-keep-loops;hoist-common-insts;no-hoist-loads-stores-with-cond-faulting;sink-common-insts;speculate-blocks;simplify-cond-branch;no-speculate-unpredictables>,slp-vectorizer,vector-combine,instcombine<max-iterations=1;no-verify-fixpoint>,loop-unroll<O3>,transform-warning,sroa<preserve-cfg>,infer-alignment,instcombine<max-iterations=1;no-verify-fixpoint>,loop-mssa(licm<allowspeculation>),alignment-from-assumptions,loop-sink,instsimplify,div-rem-pairs,tailcallelim,simplifycfg<bonus-inst-threshold=1;no-forward-switch-cond;switch-range-to-icmp;no-switch-to-lookup;keep-loops;no-hoist-common-insts;hoist-loads-stores-with-cond-faulting;no-sink-common-insts;speculate-blocks;simplify-cond-branch;speculate-unpredictables>)" on module "/b/1/clang-x86_64-debian-fast/llvm.src/compiler-rt/lib/profile/InstrProfilingFile.c"
4.	Running pass "slp-vectorizer" on function "getCurFilenameLength"
 #0 0x00000000036f06d7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x36f06d7)
 #1 0x00000000036ee18e llvm::sys::RunSignalHandlers() (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x36ee18e)
 #2 0x00000000036efabd llvm::sys::CleanupOnSignal(unsigned long) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x36efabd)
 #3 0x000000000365cb38 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
 #4 0x00007f8d95986140 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x13140)
 #5 0x00007f8d9549ad51 raise (/lib/x86_64-linux-gnu/libc.so.6+0x38d51)
 #6 0x00007f8d95484537 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22537)
 #7 0x00007f8d9548440f (/lib/x86_64-linux-gnu/libc.so.6+0x2240f)
 #8 0x00007f8d954936d2 (/lib/x86_64-linux-gnu/libc.so.6+0x316d2)
 #9 0x0000000004ea61e7 llvm::slpvectorizer::BoUpSLP::isTreeTinyAndNotFullyVectorizable(bool) const (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4ea61e7)
#10 0x0000000004f0fb5d (anonymous namespace)::HorizontalReduction::tryToReduce(llvm::slpvectorizer::BoUpSLP&, llvm::DataLayout const&, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo const&, llvm::AssumptionCache*) SLPVectorizer.cpp:0:0
#11 0x0000000004ee6e88 llvm::SLPVectorizerPass::vectorizeHorReduction(llvm::PHINode*, llvm::Instruction*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&, llvm::SmallVectorImpl<llvm::WeakTrackingVH>&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4ee6e88)
#12 0x0000000004ee72f7 llvm::SLPVectorizerPass::vectorizeRootInstruction(llvm::PHINode*, llvm::Instruction*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4ee72f7)
#13 0x0000000004edc442 llvm::SLPVectorizerPass::vectorizeChainsInBlock(llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4edc442)
#14 0x0000000004ed8f86 llvm::SLPVectorizerPass::runImpl(llvm::Function&, llvm::ScalarEvolution*, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo*, llvm::AAResults*, llvm::LoopInfo*, llvm::DominatorTree*, llvm::AssumptionCache*, llvm::DemandedBits*, llvm::OptimizationRemarkEmitter*) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4ed8f86)
#15 0x0000000004ed82fb llvm::SLPVectorizerPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x4ed82fb)
#16 0x0000000004ac51ad llvm::detail::PassModel<llvm::Function, llvm::SLPVectorizerPass, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) crtstuff.c:0:0
#17 0x00000000030f5d67 llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x30f5d67)
#18 0x0000000001059fdd llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) crtstuff.c:0:0
#19 0x00000000030fa370 llvm::ModuleToFunctionPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x30fa370)
#20 0x0000000001064d1d llvm::detail::PassModel<llvm::Module, llvm::ModuleToFunctionPassAdaptor, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) crtstuff.c:0:0
#21 0x00000000030f4bc7 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x30f4bc7)
#22 0x00000000039182b5 (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&, clang::BackendConsumer*) BackendUtil.cpp:0:0
#23 0x000000000390e6f5 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>, clang::BackendConsumer*) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x390e6f5)
#24 0x0000000003f5cbb9 clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x3f5cbb9)
#25 0x0000000005901bb6 clang::ParseAST(clang::Sema&, bool, bool) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x5901bb6)
#26 0x00000000041ff2c0 clang::FrontendAction::Execute() (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x41ff2c0)
#27 0x000000000416c4b2 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x416c4b2)
#28 0x00000000042d91b7 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/b/1/clang-x86_64-debian-fast/llvm.obj/./bin/clang+0x42d91b7)

```

</details>

https://github.com/llvm/llvm-project/pull/120198