[llvm] [Coroutines][LazyCallGraph] resumes are not really SCC (PR #116285)
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 15:54:36 PST 2025
================
@@ -1720,6 +1720,7 @@ void LazyCallGraph::addSplitRefRecursiveFunctions(
for (Function *NewFunction : NewFunctions) {
Node &NewN = initNode(*NewFunction);
+ // Make the original function reference each new function
----------------
aeubanks wrote:
this sounds exactly like what the inliner does [here](https://github.com/llvm/llvm-project/blob/504f6ce0c25b5cd721622cd444e9c428f400fd73/llvm/lib/Transforms/IPO/Inliner.cpp#L494) where we update the call graph after simplifying a function in a CGSCC pass. I'm still trying to understand if that's actually the proper solution
https://github.com/llvm/llvm-project/pull/116285
More information about the llvm-commits
mailing list