[llvm] Update cloning of the DirectXShaderCompiler repo to not include DXC tests (PR #122178)
Brian Favela via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 12:49:47 PST 2025
https://github.com/bfavela updated https://github.com/llvm/llvm-project/pull/122178
>From 0553e79b67e44242a329314b976793a846cf9ed4 Mon Sep 17 00:00:00 2001
From: "Brian Favela (from Dev Box)" <brianfavela at microsoft.com>
Date: Wed, 8 Jan 2025 17:07:13 -0500
Subject: [PATCH 1/2] Update cloning of the DirectXShaderCompiler repo to not
include tests. This prevents any unneccessary dependency on TAEF when
building as it's not used for dxil-dis testing
---
llvm/tools/dxil-dis/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/tools/dxil-dis/CMakeLists.txt b/llvm/tools/dxil-dis/CMakeLists.txt
index d0541fcf802e98..ad540bbd53df62 100644
--- a/llvm/tools/dxil-dis/CMakeLists.txt
+++ b/llvm/tools/dxil-dis/CMakeLists.txt
@@ -38,7 +38,7 @@ ExternalProject_Add(DXC
${GIT_SETTINGS}
SOURCE_DIR ${SOURCE_DIR}
BINARY_DIR ${BINARY_DIR}
- CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On
+ CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off
BUILD_COMMAND ${CMAKE_COMMAND} --build ${BINARY_DIR} --target llvm-dis
BUILD_BYPRODUCTS ${BINARY_DIR}/bin/llvm-dis
INSTALL_COMMAND ""
>From e5f0ee624c24e56f817c9476b782e4df6b44d92b Mon Sep 17 00:00:00 2001
From: "Brian Favela (from Dev Box)" <brianfavela at microsoft.com>
Date: Thu, 9 Jan 2025 15:49:19 -0500
Subject: [PATCH 2/2] Remove superfluous LLVM_INCLUDE_TESTS define
---
llvm/tools/dxil-dis/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/tools/dxil-dis/CMakeLists.txt b/llvm/tools/dxil-dis/CMakeLists.txt
index ad540bbd53df62..1e775301064204 100644
--- a/llvm/tools/dxil-dis/CMakeLists.txt
+++ b/llvm/tools/dxil-dis/CMakeLists.txt
@@ -38,7 +38,7 @@ ExternalProject_Add(DXC
${GIT_SETTINGS}
SOURCE_DIR ${SOURCE_DIR}
BINARY_DIR ${BINARY_DIR}
- CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off
+ CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off
BUILD_COMMAND ${CMAKE_COMMAND} --build ${BINARY_DIR} --target llvm-dis
BUILD_BYPRODUCTS ${BINARY_DIR}/bin/llvm-dis
INSTALL_COMMAND ""
More information about the llvm-commits
mailing list