[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 07:07:24 PST 2025


================
@@ -137,6 +137,10 @@ llvm::AllocaInst *CodeGenFunction::CreateTempAlloca(llvm::Type *Ty,
     Alloca =
         new llvm::AllocaInst(Ty, CGM.getDataLayout().getAllocaAddrSpace(),
                              ArraySize, Name, AllocaInsertPt->getIterator());
+  if (Alloca->getName() != Name.str() &&
----------------
gbMattN wrote:

> I don't see the point of the `Alloca->getName() != Name.str()` check; it will almost always fail. (In release builds of clang, we suppress instruction names, so `Alloca->getName()` is just the empty string.)

I'm still getting names from Allocas when I build in release mode, is there some other flag that does this?


https://github.com/llvm/llvm-project/pull/119387


More information about the llvm-commits mailing list