[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

[Eli Friedman via llvm-commits]

================
@@ -137,6 +137,10 @@ llvm::AllocaInst *CodeGenFunction::CreateTempAlloca(llvm::Type *Ty,
     Alloca =
         new llvm::AllocaInst(Ty, CGM.getDataLayout().getAllocaAddrSpace(),
                              ArraySize, Name, AllocaInsertPt->getIterator());
+  if (Alloca->getName() != Name.str() &&
----------------
efriedma-quic wrote:

I don't see the point of the `Alloca->getName() != Name.str()` check; it will almost always fail.  (In release builds of clang, we suppress instruction names, so `Alloca->getName()` is just the empty string.)

https://github.com/llvm/llvm-project/pull/119387