[llvm] [HLSL] [DirectX] translate llvm fast math flags to llvm 3.7 fast math flags (PR #122025)

Brian Favela via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 09:15:54 PST 2025


================
@@ -759,10 +759,6 @@ uint64_t DXILBitcodeWriter::getOptimizationFlags(const Value *V) {
       Flags |= bitc::NoSignedZeros;
     if (FPMO->hasAllowReciprocal())
       Flags |= bitc::AllowReciprocal;
-    if (FPMO->hasAllowContract())
-      Flags |= bitc::AllowContract;
-    if (FPMO->hasApproxFunc())
----------------
bfavela wrote:

Ah, good point... I don't want to stand in the way of this getting in, but neither is "AllowContract". Should we be asserting on these instead? (it seems "UnsafeAlgebra" was just renamed to "AllowReassoc")
https://github.com/microsoft/DirectXShaderCompiler/blob/070d0d5a2beacef9eeb51037a9b04665716fd6f3/include/llvm/IR/Operator.h#L171

https://github.com/llvm/llvm-project/pull/122025


More information about the llvm-commits mailing list