[llvm] [ADT] Specialize ValueIsPresent for PointerUnion (PR #121847)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 01:42:15 PST 2025


================
@@ -259,6 +259,17 @@ struct CastInfo<To, const PointerUnion<PTs...>>
                                           CastInfo<To, PointerUnion<PTs...>>> {
 };
 
+// The default implementation of isPresent() for nullable types returns true
+// if the active member is not the first one, even if its value is nullptr.
+// Override the default behavior to return false for all possible null values.
+template <typename... PTs>
+struct ValueIsPresent<PointerUnion<PTs...>,
+                      std::enable_if_t<IsNullable<PointerUnion<PTs...>>>> {
----------------
nikic wrote:

Is this enable_if needed? Isn't PointerUnion always nullable because it satisfies `std::is_constructible_v<PointerUnion<PTs...>, std::nullptr_t>`?

https://github.com/llvm/llvm-project/pull/121847


More information about the llvm-commits mailing list