[llvm] [RISCV][CG]Use processShuffleMasks for per-register shuffles (PR #121765)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 14:24:32 PST 2025


preames wrote:

> > > > Rework of the reverted #120803
> > > 
> > > 
> > > Can you summarize the functional fix? What changed? _In particular_, which is the test which catches the prior functional bug?
> > 
> > 
> > Incorrectly calculated the destination registers. To fix this had to introduce a new boolean flag, that shows the start of filling a new destination register.
> 
> It was not required previously, because we used only for the cost estimation, where it is not important, and for type splitting, where we had exactly 2 sources and 2 destinations only and could handle it without the flag.

Which test now covers the previous functional bug?  (i.e. crashes with the prior version of the patch)

https://github.com/llvm/llvm-project/pull/121765


More information about the llvm-commits mailing list