[llvm] 2ab447a - Fix dangling IPOAmendableCB function_ref. (#120698)

[via llvm-commits]

Author: Haojian Wu
Date: 2025-01-07T21:53:00+01:00
New Revision: 2ab447ad6983fb9f22f2fea480f3857522750860

URL: https://github.com/llvm/llvm-project/commit/2ab447ad6983fb9f22f2fea480f3857522750860
DIFF: https://github.com/llvm/llvm-project/commit/2ab447ad6983fb9f22f2fea480f3857522750860.diff

LOG: Fix dangling IPOAmendableCB function_ref. (#120698)

The `IPOAmendableCB`'s type is `llvm::function_ref`, it is error-prone
to write code (e.g.
https://github.com/llvm/llvm-project/blob/5656cbca52545e608f6fb8b7c9a778c7c9b4b468/llvm/lib/Transforms/IPO/OpenMPOpt.cpp#L5812)
that assign a temporary lambda to an `IPOAmendableCB` object, which is a
use-after-free issue.

This patch changes the `IPOAmendableCB` to `std::function`, to avoid the
dangling issue.

Added: 
    

Modified: 
    llvm/include/llvm/Transforms/IPO/Attributor.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h
index a8ee3cd531e490..28bce7b906652f 100644
--- a/llvm/include/llvm/Transforms/IPO/Attributor.h
+++ b/llvm/include/llvm/Transforms/IPO/Attributor.h
@@ -1478,7 +1478,7 @@ struct AttributorConfig {
   /// The name of the pass running the attributor, used to emit remarks.
   const char *PassName = nullptr;
 
-  using IPOAmendableCBTy = function_ref<bool(const Function &F)>;
+  using IPOAmendableCBTy = std::function<bool(const Function &F)>;
   IPOAmendableCBTy IPOAmendableCB;
 };